refactor: optimize create job task of control plane #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimized create job task of control plane by changing the DB write task to insert multiple entries in batch, instead of original method of inserting one by one. changing it to insert multiple entries at once at DB makes the overall create job procedure faster. in addition, nginx timeout and message size parameters are updated for scalable create job task.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 14.85% 14.86% +0.01%
==========================================
Files 48 48
Lines 2835 2832 -3
==========================================
Hits 421 421
+ Misses 2385 2382 -3
Partials 29 29
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimized create job task of control plane by changing the DB write task to insert multiple entries in batch, instead of original method of inserting one by one. changing it to insert multiple entries at once at DB makes the overall create job procedure faster. in addition, nginx timeout and message size parameters are updated for scalable create job task.
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist