fix: slow tx task termination #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx task termination is slow because putting EMPTY_PAYLOAD was never executed. This was because channel.remove(end) is called that end is going to be removed. Hence, the length of channel._ends is always zero. To address the issue, in channel.remove(), puting EMPTY_PAYLOAD into the tx queue is implemented. With this, every time channel.remove() is called, the given end's tx task is safely terminated.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 15.15% 15.15%
=======================================
Files 48 48
Lines 2778 2778
=======================================
Hits 421 421
Misses 2328 2328
Partials 29 29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tx task termination is slow because putting EMPTY_PAYLOAD was never executed. This was because channel.remove(end) is called that end is going to be removed. Hence, the length of channel._ends is always zero. To address the issue, in channel.remove(), puting EMPTY_PAYLOAD into the tx queue is implemented. With this, every time channel.remove() is called, the given end's tx task is safely terminated.
Type of Change
Checklist