feddyn algorithm correction #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FedDyn algorithm does not send out the same model for training as it uses for evaluation. This is now implemented in this PR. The labels will be changed to type long before being sent to the loss function in order to avoid NaN values as output. Lastly, the FedDynRegularizer class now has a .to(device) function in order to transfer the information as needed for subprocesses that use the GPU.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #401 +/- ##
=======================================
Coverage 15.15% 15.15%
=======================================
Files 48 48
Lines 2778 2778
=======================================
Hits 421 421
Misses 2328 2328
Partials 29 29 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FedDyn algorithm does not send out the same model for training as it uses for evaluation. This is now implemented in this PR.
The labels will be changed to type long before being sent to the loss function in order to avoid NaN values as output.
Lastly, the FedDynRegularizer class now has a .to(device) method in order to transfer the information as needed for subprocesses that use the GPU.