Impove tasklet composition extensibility #397
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 15.15% 15.15%
=======================================
Files 48 48
Lines 2778 2778
=======================================
Hits 421 421
Misses 2328 2328
Partials 29 29 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lib/python/flame/mode/composer.py
Outdated
| for child in self.chain[parent_t]: | ||
| q.put(child) | ||
|
|
||
| def insert_after(self, alias, new_tasklet): |
There was a problem hiding this comment.
can we use insert_before to implement insert_after?
you basically need to get the child of the tasklet that you want to do "insert_after" and call "insert_before" with the child's tasklet. I am not certain if this way has some ramification though.
This way, you can probably make the implementation more concise.
There was a problem hiding this comment.
There will still be the case when inserting after the last tasklet. I created a facade of insert, which calls before/after based on the after flag, to make further changes backwards compatible. And I'm working on a broader approach to the problem.
|
@elqurio Regarding the commit log, please use a short title (topic) and add two new lines before detailed description is added. This way, when |
Addressed this one |
This PR improves the extensibility of tasklet composition by allowing the developer to extend the tasklet set on the original `Composer` by declaring new tasklets under `CloneComposer` context and then use the composer to get originally implmented tasklets by alias and perform composition on them. Implemented tasklet/composer operations: - `insert_before` which inserts a tasklet before the target tasklet - `insert_after` which inserts a tasklet after the target tasklet - `replace_with` which replaces the target tasklet with the new tasklet - `remove` which removes the target tasklet The implemented operations work with loop edges, except for `remove` which will raise NotImplementedError if the target tasklet has loop edges. This PR demonstrates the extensibility of tasklet composition by refactoring the existing coord_syncfl mode to use the new extensibility (demonstrating the reduction in LOC needed to achieve same results).
Description
This PR improves the extensibility of tasklet composition by allowing the developer to extend the tasklet set on the original
Composerby declaring new tasklets underCloneComposercontext and then use the composer to get originally implmented tasklets by alias and perform composition on them. Implemented tasklet/composer operations:insert_beforewhich inserts a tasklet before the target taskletinsert_afterwhich inserts a tasklet after the target taskletreplace_withwhich replaces the target tasklet with the new taskletremovewhich removes the target taskletThe implemented operations work with loop edges, except for
removewhich will raise NotImplementedError if the target tasklet has loop edges.This PR demonstrates the extensibility of tasklet composition by refactoring the existing coord syncfl mode to use the new extensibility (demonstrating the reduction in LOC needed to achieve same results).
Type of Change
Checklist