Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove legacy code #393

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

myungjin
Copy link
Contributor

@myungjin myungjin commented Apr 5, 2023

Description

The legacy code that has no effect creates confusion. Hence, it is now purged.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@myungjin myungjin requested a review from lkurija1 April 5, 2023 02:24
alexandruuBytex
alexandruuBytex previously approved these changes Apr 5, 2023
Copy link
Contributor

@alexandruuBytex alexandruuBytex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The legacy code that has no effect creates confusion. Hence, it is now
purged.
Copy link
Collaborator

@GustavBaumgart GustavBaumgart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myungjin myungjin merged commit 2622d11 into cisco-open:main Apr 6, 2023
@myungjin myungjin deleted the cleanup_dead_code_in_sdk branch April 6, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants