refactor: move syncfl files #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 15.13% 15.13%
=======================================
Files 48 48
Lines 2775 2775
=======================================
Hits 420 420
Misses 2327 2327
Partials 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lkurija1
previously approved these changes
Mar 31, 2023
myungjin
force-pushed
the
move_syncfl_files
branch
2 times, most recently
from
1be35a1
to
5ac936b
Compare
While top-level horizontal files (top_aggregator.py, middle_aggregator.py and trainer.py) are basis of other modes under horizontal category, the directory structure is not well organized. These files are now moved into horizontal/syncfl folder while we keep backward compatibility.
myungjin
force-pushed
the
move_syncfl_files
branch
from
5ac936b
to
96fd634
Compare
lkurija1
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While top-level horizontal files (top_aggregator.py, middle_aggregator.py and trainer.py) are basis of other modes under horizontal category, the directory structure is not well organized.
These files are now moved into horizontal/syncfl folder while we keep backward compatibility.
Type of Change
Checklist