Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove non-orchestration mode #374

Merged

Conversation

openwithcode
Copy link
Contributor

Remove non-orchestration mode from the project as it's not maintained anymore, at least for the medium term.

The only mode flame will have for now will be the orchestration mode, which means that all the wokers are managed by the flame system.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov-commenter
Copy link

Codecov Report

Merging #374 (386f087) into main (225c86d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   14.48%   14.55%   +0.06%     
==========================================
  Files          48       48              
  Lines        2768     2756      -12     
==========================================
  Hits          401      401              
+ Misses       2338     2327      -11     
+ Partials       29       28       -1     
Impacted Files Coverage Δ
cmd/controller/app/job/builder.go 68.07% <100.00%> (+2.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments.

api/job_components.partials.yml Show resolved Hide resolved
cmd/flamectl/resources/job/job.go Outdated Show resolved Hide resolved
pkg/openapi/model_data_spec.go Show resolved Hide resolved
docs/04-examples.md Outdated Show resolved Hide resolved
@openwithcode openwithcode force-pushed the remove_non_orchestration_mode branch 3 times, most recently from 0d64714 to c22eacc Compare March 28, 2023 12:46
…ained anymore, at least for the medium term.

 The only mode flame will have for now will be the orchestration mode, which means that all the wokers are managed by the flame system.
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openwithcode openwithcode merged commit e060ce8 into cisco-open:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants