Create a run minikube script #363
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 14.39% 14.39%
=======================================
Files 48 48
Lines 2771 2771
=======================================
Hits 399 399
Misses 2354 2354
Partials 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
.golangci.yml
Outdated
| @@ -9,6 +9,8 @@ run: | |||
| - internal/robustio | |||
| skip-files: | |||
| - ".*\\_test\\.go$" | |||
| - pkg/openapi/api_design_schemas.go | |||
| - pkg/openapi/api_jobs.go | |||
There was a problem hiding this comment.
This will remove these files from all linter rules. This is not desirable.
If you are doing this because there is pkg/openapi/helpers.go listed here, pkg/openapi/helpers.go is also wrongly placed. This is not the best example you can refer to.
My request was to selectively exclude these file only for dupl check.
Is it not possible to use exclude-rules? see https://github.com/cisco-open/flame/blob/main/.golangci.yml#L129-L132.
.github/workflows/presubmits.yml
Outdated
| @@ -67,4 +67,4 @@ jobs: | |||
| go-version: 1.17.x | |||
|
|
|||
| - name: golangci-lint | |||
| uses: golangci/golangci-lint-action@0ad9a0988b3973e851ab0a07adf248ec2e100376 # v3 | |||
| uses: golangci/golangci-lint-action@0ad9a0988b3973e851ab0a07adf248ec2e100376 # v3 | |||
There was a problem hiding this comment.
revert this change. Don't create this unnecessary change.
alexandruuBytex
force-pushed
the
run-minikube-script
branch
from
ee76a8f
to
761930a
Compare
alexandruuBytex
force-pushed
the
run-minikube-script
branch
from
761930a
to
5a7e50b
Compare
This reverts commit 6781965.
Create a run minikube script (cisco-open#363) * Create a run minikube script * Remove the build-image command * Configure golangci.yml to add the linter exceptions * Revert changes from .golangci.yml --------- Co-authored-by: Alex Ungurean <aungurea@cisco.com> Move dataSpec and modelSpec to separate json files Remove aggregators and trainers Remove aggregators and trainers Modify the test to respect the new structure
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist