medmnist example update #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myungjin
reviewed
Jan 19, 2023
| @@ -1,19 +1,3 @@ | |||
| # Copyright 2022 Cisco Systems, Inc. and its affiliates | |||
There was a problem hiding this comment.
Please reinstate the copyright text.
| @@ -1,31 +1,15 @@ | |||
| # Copyright 2022 Cisco Systems, Inc. and its affiliates | |||
| # logger.info(f"Test Loss: {val_loss}") | ||
| # logger.info(f"Test Accuracy: {val_acc}") | ||
| # logger.info(f"Testset Size: {self.dataset_size}") | ||
| logger.info(f"Dataset: {str(self.config.dataset)}") |
There was a problem hiding this comment.
I think we can remove this line.
| self.update_metrics({"Val Loss": val_loss, "Val Accuracy": val_acc, "Testset Size": self.dataset_size}) | ||
| # logger.info(f"Test Loss: {val_loss}") | ||
| # logger.info(f"Test Accuracy: {val_acc}") | ||
| # logger.info(f"Testset Size: {self.dataset_size}") |
There was a problem hiding this comment.
Perhaps we can uncomment these three lines to check the progresses of the evaluate part.
There was a more recent version of this example available outside the lib directory (examples/medmnist/medmnist.zip). This example has now been used to update the files in lib/python/flame/examples/medmnist.
GustavBaumgart
force-pushed
the
medmnist
branch
from
2941c1d
to
60c743b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a more recent version of this example available outside the lib directory (examples/medmnist/medmnist.zip).
This example has now been used to update the files in lib/python/flame/examples/medmnist.