Add --local-img flag to the shell script to use dev tag for local testing

[Divlik]

Add args to start command for flame shell script to replace the tag name inside helmchart values file

[myungjin]

thanks for the PR. left two comments.

[myungjin]

This can be buggy because of line 218 (https://github.com/cisco-open/flame/pull/275/files#diff-c26314cc215f8cfbcb4f96f0ae8834a637f638dde7611c57148d786f9a3bfa48R218) which compares against a positional parameter.

I'd recommend the following command syntax:
./flame.sh <start [--exposedb] [--localimg] | stop>

I'd recommend to use "--localimg" to make the purpose of the argument is clearer. "--local" doesn't convey that we are using a local image.

The following example might be useful:

exposedb=false
tag=""
verb=${@:$OPTIND:1}
shift;

for arg in "$@"; do
    case "$arg" in
	"--exposedb") exposedb=true;;
	"--localimg") tag="dev";;
	*) echo "unknown option: $arg"; exit 1;;
    esac
done

echo $verb $exposedb $tag

Here you can use verb to replace $1 in lines 223 and 233.

The usage syntax in line 243 should be updated (https://github.com/cisco-open/flame/pull/275/files#diff-c26314cc215f8cfbcb4f96f0ae8834a637f638dde7611c57148d786f9a3bfa48R243).

[myungjin]

instead of using "$1" and "$2" in the start function, it may be better to assign variables for them.

exposedb=$1
tag=$2

[myungjin]

Minor comments left. Please address them. Otherwise, lgtm.

[myungjin]

Remove this line. It's not necessary.

[myungjin]

Use four spaces for indentation.

[myungjin]

lgtm