feat: 'continue' primitive in tasklet #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add 'continue' primitive in the tasklet code of the flame library. The 'continue' primitive is used to move back to the start of loop when a certain condition is met. A condition is defined as a function, which will be set via set_continue_fn member function. As an example use case of 'continue' primitive, a middle aggregator code is extended in the following way: If no trainer join a channel that the middle aggregator is waiting on for a minute, the middle aggregator gives up waiting and updates the top aggregator with dummy weights so that the top aggregator can be unblocked. Then, the middle aggregator goes back to the start of the loop so that it can retrieve model weights of a new global model from the top aggregator.
Divlik
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add 'continue' primitive in the tasklet code of the flame library. The 'continue' primitive is used to move back to the start of loop when a certain condition is met. A condition is defined as a function, which will be set via set_continue_fn member function.
As an example use case of 'continue' primitive, a middle aggregator code is extended in the following way: If no trainer join a channel that the middle aggregator is waiting on for a minute, the middle aggregator gives up waiting and updates the top aggregator with dummy weights so that the top aggregator can be unblocked. Then, the middle aggregator goes back to the start of the loop so that it can retrieve model weights of a new global model from the top aggregator.