Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo and logic error #255

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix: typo and logic error #255

merged 1 commit into from
Oct 20, 2022

Conversation

GaoxiangLuo
Copy link
Collaborator

Fixed a typo in the skeleton code of middle aggregator; fixed a logic error in hybrid skeleton code as a message can contain more than one type of content; updated config file for MedMNIST for latest version of flame.

type file changes
modified lib/python/flame/mode/horizontal/middle_aggregator.py fatal typo
modified lib/python/flame/mode/hybrid/trainer.py if/else statement logic error
modified lib/python/flame/examples/medmnist/aggregator/config.json remove mlflow
modified lib/python/flame/examples/medmnist/aggregator/config.json remove mlflow

Fixed a typo in the skeleton code of middle aggregator; fixed a logic error in hybrid skeleton code as a message can contain more than one type of content; updated config file for medmnist for latest version of flame.
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. lgtm!

@myungjin myungjin merged commit 77e1f26 into cisco-open:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants