Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete code api endpoint #240

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

RaviKhandavilli
Copy link
Contributor

added boiler plate code for the delete code in api endpoints

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment left; please consider to address it.

api/design_api.partials.yml Outdated Show resolved Hide resolved
pkg/openapi/api_design_codes.go Outdated Show resolved Hide resolved
added boiler plate code for the delete code in api endpoints
@codecov-commenter
Copy link

Codecov Report

Merging #240 (88db735) into main (29d9ed6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   22.41%   22.41%           
=======================================
  Files          35       35           
  Lines        1593     1593           
=======================================
  Hits          357      357           
  Misses       1226     1226           
  Partials       10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. lgtm.

@RaviKhandavilli RaviKhandavilli merged commit 4b2c339 into cisco-open:main Oct 3, 2022
@RaviKhandavilli RaviKhandavilli deleted the deletecode branch October 9, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants