Updated spec for deploymentConfig #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 22.45% 22.45%
=======================================
Files 35 35
Lines 1590 1590
=======================================
Hits 357 357
Misses 1223 1223
Partials 10 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
myungjin
reviewed
Aug 11, 2022
api/computes_components.partials.yml
Outdated
| type: array | ||
| items: | ||
| $ref: '#/components/schemas/AgentKV' | ||
| $ref: '#/components/schemas/AgentKV' |
There was a problem hiding this comment.
minor: Can you rename https://github.com/cisco-open/flame/pull/212/files#diff-6eacedc6dd629aaf9f74f99ecffd0d70ee1f5a8a4bce1701959cfcf04821ba63L91 to AgentKVs as well?
This pr updates the agentKV field of deployementConfig spec to a simple map instead of a list of maps.
dhruvsgarg
force-pushed
the
fix_deplyConfig_spec
branch
from
43a963c
to
de9bd68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates the agentKV field of deployementConfig spec to a simple map instead of a list of maps.