Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding few restAPIs for deployer #194

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

dhruvsgarg
Copy link
Contributor

This pr adds restAPIs for the deployer to be able to exchange information with the controller.

@dhruvsgarg dhruvsgarg requested a review from myungjin July 21, 2022 00:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #194 (5a061e2) into main (0d0ac61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   21.26%   21.26%           
=======================================
  Files          35       35           
  Lines        1632     1632           
=======================================
  Hits          347      347           
  Misses       1275     1275           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0ac61...5a061e2. Read the comment docs.

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR. defining api spec well is a hard task. I left some comments. please consider to accommodate them.

api/computes_api.partials.yml Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
api/computes_api.partials.yml Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
api/computes_api.partials.yml Outdated Show resolved Hide resolved
@dhruvsgarg dhruvsgarg force-pushed the add_compute_apis branch 2 times, most recently from c1397c8 to 17350f1 Compare July 21, 2022 21:05
This pr adds restAPIs for the deployer to be able to exchange information with the controller.
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR while there is one more minor comment. Please feel free to visit this comment in a future PR.

api/computes_components.partials.yml Show resolved Hide resolved
@myungjin myungjin merged commit cb15fb9 into cisco-open:main Jul 22, 2022
@dhruvsgarg dhruvsgarg deleted the add_compute_apis branch July 27, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants