Initial end-to-end pipeline for deployer #193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 21.79% 21.26% -0.54%
==========================================
Files 35 35
Lines 1592 1632 +40
==========================================
Hits 347 347
- Misses 1235 1275 +40
Partials 10 10
Continue to review full report at Codecov.
|
cmd/notifier/app/eventroute.go
Outdated
| func (s *notificationServer) getDeployEventChannel(computeId string) chan *pbNotify.DeployEvent { | ||
| var eventCh chan *pbNotify.DeployEvent | ||
|
|
||
| s.mutex.Lock() |
There was a problem hiding this comment.
you are using this mutex for both deploy event as well as job event. Is this fine? do we need separate mutexes for each of the event? can you explain your logic?
| ComputeIds: computeIds, | ||
| } | ||
|
|
||
| for _, taskInfo := range h.tasksInfo { |
There was a problem hiding this comment.
defaulthandler object has jobId field; no need to go through tasksInfo.
dhruvsgarg
force-pushed
the
deployer_pipeline_simple
branch
from
c0a4880
to
4f298de
Compare
cmd/notifier/app/eventroute.go
Outdated
| s.mutex.Lock() | ||
| delete(s.eventQueues, taskId) | ||
| s.mutex.Unlock() | ||
| s.mutex_job.Lock() |
There was a problem hiding this comment.
Use camelCase style.
| s.mutex_job.Lock() | |
| s.mutexJob.Lock() |
cmd/notifier/app/server.go
Outdated
| jobEventQueues map[string]chan *pbNotify.JobEvent | ||
| deployEventQueues map[string]chan *pbNotify.DeployEvent | ||
| mutex_job sync.Mutex | ||
| mutex_deploy sync.Mutex |
There was a problem hiding this comment.
Use camelCase style.
See https://go.dev/doc/effective_go#mixed-caps
dhruvsgarg
force-pushed
the
deployer_pipeline_simple
branch
from
4f298de
to
710aa30
Compare
This PR implements the eventroute and triggerroute code for notifier to receive and send deployment events. The controller triggers an add resource event while allocating computes and this event is received at the deployer.
dhruvsgarg
force-pushed
the
deployer_pipeline_simple
branch
from
710aa30
to
814fe16
Compare
This PR implements the eventroute and triggerroute code for notifier to receive and send deployment events. The controller triggers an add resource event while allocating computes and this event is received at the deployer.