Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establishing deployer notifier connection #183

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

dhruvsgarg
Copy link
Contributor

This PR creates a grpc connection between the deployer and notifier. The connection will later be used to send events.

This PR creates a grpc connection between the deployer and notifier. The connection will later be used to send events.
@dhruvsgarg dhruvsgarg requested a review from myungjin July 13, 2022 23:59
@codecov-commenter
Copy link

Codecov Report

Merging #183 (4cd3bfa) into main (8e40439) will increase coverage by 0.05%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   21.16%   21.21%   +0.05%     
==========================================
  Files          35       35              
  Lines        1545     1560      +15     
==========================================
+ Hits          327      331       +4     
- Misses       1208     1219      +11     
  Partials       10       10              
Impacted Files Coverage Δ
cmd/deployer/cmd/root.go 19.29% <25.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e40439...4cd3bfa. Read the comment docs.

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myungjin myungjin merged commit 14d3699 into cisco-open:main Jul 14, 2022
@dhruvsgarg dhruvsgarg deleted the conn_deployer_notifier branch July 14, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants