Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misprint #180

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Misprint #180

merged 2 commits into from
Jul 15, 2022

Conversation

ritvik-verma
Copy link
Contributor

No description provided.

myungjin
myungjin reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks; one comment left.

examples/adult/README.md
@@ -25,12 +25,11 @@ Note: to understand relationship between schema and code, unzip adult.zip and ch

### Step 4: create a job
```

flamectl create job job.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add bash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@codecov-commenter
Copy link

Codecov Report

Merging #180 (6e9a87a) into main (8e40439) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   21.16%   21.21%   +0.05%     
==========================================
  Files          35       35              
  Lines        1545     1560      +15     
==========================================
+ Hits          327      331       +4     
- Misses       1208     1219      +11     
  Partials       10       10
Impacted Files Coverage Δ
cmd/deployer/cmd/root.go 19.29% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e40439...6e9a87a. Read the comment docs.

myungjin
myungjin approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@myungjin myungjin merged commit c4a02eb into cisco-open:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjin myungjin myungjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ritvik-verma @codecov-commenter @myungjin