Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making docker driver default. #171

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Making docker driver default. #171

merged 3 commits into from
Jul 12, 2022

Conversation

ritvik-verma
Copy link
Contributor

If not used, minikube start doesn't work after minikube delete.

@codecov-commenter
Copy link

Codecov Report

Merging #171 (8fc30d8) into main (53594f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   21.29%   21.29%           
=======================================
  Files          34       34           
  Lines        1503     1503           
=======================================
  Hits          320      320           
  Misses       1173     1173           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53594f9...8fc30d8. Read the comment docs.

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myungjin myungjin merged commit 3536253 into cisco-open:main Jul 12, 2022
dhruvsgarg added a commit to dhruvsgarg/flame that referenced this pull request Jul 12, 2022
misc: add missing license (cisco-open#173)

Several files that are recently added don't have license statements.
license statements are added in those files.

Making docker driver default. (cisco-open#171)

Updated endpoints and components, removed registration-db controller code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants