Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: reduce distributed learning code complexity #161

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

GaoxiangLuo
Copy link
Collaborator

This commit reduces the complexity of the distributed learning code by storing the ends who agree with the ring topology at a time, so that a trainer in a ring won't send weights message to trainers outside of the ring. Meanwhile, a new trainer's arrival message won't send to the trainers in a ring either. Hence, the moment that a new trainer fetches the global optimal weights will be when the new trainer is in the ring.

type file changes
modified lib/python/flame/mode/distributed/trainer.py store ends in a ring separately

@GaoxiangLuo GaoxiangLuo added the enhancement New feature or request label Jun 29, 2022
@GaoxiangLuo GaoxiangLuo self-assigned this Jun 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #161 (e1a2629) into main (77ed492) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   21.29%   21.29%           
=======================================
  Files          34       34           
  Lines        1503     1503           
=======================================
  Hits          320      320           
  Misses       1173     1173           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ed492...e1a2629. Read the comment docs.

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great to me!

@myungjin myungjin merged commit 4a3c559 into cisco-open:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants