Skip to content

Commit

Permalink
Added http support for apiserver.
Browse files Browse the repository at this point in the history
  • Loading branch information
raresgaia123 committed Nov 16, 2023
1 parent 6acb55c commit fae4e3f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fiab/helm-chart/control/templates/apiserver-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ metadata:
namespace: {{ .Release.Namespace }}
{{- if .Values.ingress.annotations }}
annotations:
{{- range $key, $value := .Values.ingress.annotations }}
{{- range $key, $value := .Values.ingress.annotationsNoTls }}
{{ $key }}: {{ tpl $value $ | quote }}
{{- end }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion fiab/helm-chart/control/templates/dashboard-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ metadata:
namespace: {{ .Release.Namespace }}
{{- if .Values.ingress.annotations }}
annotations:
{{- range $key, $value := .Values.ingress.annotations }}
{{- range $key, $value := .Values.ingress.annotationsNoTls }}
{{ $key }}: {{ tpl $value $ | quote }}
{{- end }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion fiab/helm-chart/control/templates/mlflow-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ metadata:
namespace: {{ .Release.Namespace }}
{{- if .Values.ingress.annotations }}
annotations:
{{- range $key, $value := .Values.ingress.annotationsMlflow }}
{{- range $key, $value := .Values.ingress.annotationsNoTls }}
{{ $key }}: {{ tpl $value $ | quote }}
{{- end }}
{{- end }}
Expand Down
5 changes: 4 additions & 1 deletion fiab/helm-chart/control/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,15 @@ ingress:
cert-manager.io/cluster-issuer: selfsigned
# In mlflow, selfsigned certificate raises SSLCertVerificationError
# So, fiab env disable tls; tls can be enabled with a legitimate cert
annotationsMlflow:
annotationsNoTls:
nginx.ingress.kubernetes.io/rewrite-target: /
# In case there is 413 error,
# refer to https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#custom-max-body-size
# set nginx.ingress.kubernetes.io/proxy-body-size to 0 to disable the limit
nginx.ingress.kubernetes.io/proxy-body-size: "512m"
nginx.ingress.kubernetes.io/proxy-connect-timeout: "60000"
nginx.ingress.kubernetes.io/proxy-read-timeout: "60000"
nginx.ingress.kubernetes.io/proxy-send-timeout: "60000"

frontDoorUrl:
apiserver: apiserver.flame.test
Expand Down

0 comments on commit fae4e3f

Please sign in to comment.