Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): rename killer to enforcer #2887

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

mozillazg
Copy link
Contributor

Closes #2517

Description

update docs to use NotifyEnforcer

Changelog

chore(docs): rename killer to enforcer

@mozillazg mozillazg requested a review from a team as a code owner September 7, 2024 09:21
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit f028481
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66e43c704bfaa4000914517e
😎 Deploy Preview https://deploy-preview-2887--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this, let me just ask a few question first :)

bpf/process/types/basic.h Show resolved Hide resolved
@mtardy mtardy requested a review from kkourt September 12, 2024 10:08
@mtardy
Copy link
Member

mtardy commented Sep 12, 2024

Hey! I think we can merge that, thanks for the work! Could you bump the patch version of the CRD since those changes touch it, it's just here (don't forget to run make crds and make vendor after that):

const CustomResourceDefinitionSchemaVersion = "1.3.0"

And can you please squash your commits into the first one when it's done?

@mtardy mtardy removed the request for review from tpapagian September 12, 2024 10:16
@mtardy mtardy added the release-note/misc This PR makes changes that have no direct user impact. label Sep 12, 2024
closes cilium#2517

Signed-off-by: mozillazg <mozillazg101@gmail.com>
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtardy mtardy merged commit 0fb2116 into cilium:main Sep 13, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update docs to use NotifyEnforcer
3 participants