Refactor and rename eventcache metrics #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/metrics
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lambdanis
force-pushed
the
pr/lambdanis/eventcache-metrics
branch
from
34f1c1c
to
38c95bd
Compare
kevsecurity
approved these changes
Sep 2, 2024
There are no functional changes in this commit, only moving code around. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Use new helpers from pkg/metrics to define custom metrics and collector. There are no functional changes in this commit. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
It's duplicating tetragon_event_cache_<entry_type>_errors_total metrics, which will be removed in a follow up commit. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
…rics
They're now replaced by more intuitive metrics
tetragon_event_cache_fetch_failures_total{entry_type="<entry_type>"}
Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Renaming tetragon_event_cache_accesses_total metric to tetragon_event_cache_inserts_total. I would read "accesses" as cache reads, not inserts, so the new name is more intuitive I think. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Use new helpers from pkg/metrics to define custom metrics and collector. Rename the metric to tetragon_event_cache_fetch_retries_total, to make it clear what is being retried. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
Use new helpers from pkg/metrics to define custom metrics and collector. There are no functional changes in this commit. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/eventcache-metrics
branch
from
38c95bd
to
3ec8ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Part of #2785
Part of #2798
Part of #2786