Fix blocks overflowing over the top of octree bounds

[NotStirred]

Due to an incorrect maxDimension calculation

This happened because we were trying to set a cube of height 16 less than 16 blocks from the edge of the octree. (which was then masked to within bounds and so wrapped)
Thoughts on adding some assertions in packedoctree that the arguments are even valid?

[leMaik]

Assertions would be great, but why in PackedOctree? Why not throw some IllegalArgumentExceptions in Octree to fix these bugs fast? Or at least warn and tell the user to report a bug?

[NotStirred]

👍 I'd forgotten that the octree wrapper existed

[NotStirred]

Bounds on the assertions are off-by-one.
if the octree is 32 size, and we're placing a 16 size cube at 16,0,0 it's checking 16+16 < 32 which is obviously not right
needs to be <=

Will fix tonight

[NotStirred]

Thoughts on splitting calculateOctreeOrigin into two methods, one for legacy one for current?

Also this method is pretty horrible, internally modifies this.origin but returns requiredDepth with a boolean flag for legacy path

[leMaik]

@NotStirred Splitting calculateOctreeOrigin or refactoring it not to be horrible sounds good, probably something for another PR. 👍