Merge 0.4 #986
Merged
Merge 0.4 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7dfd8ca)
(cherry picked from commit a2fb121)
(cherry picked from commit 05b865d)
Currently CI is only run on changes to specific files. The list of these files incomplete and would likely get outdated again if it were expanded. Exluding specific files would be a shorter, more stable list. However, the changelog is only kept for posterity and the readme has seen all of two commits in the past three years that wouldn't have triggered CI by changing other files as well, so don't bother and just run CI for any changed file.
Ensures future changes to break it again.
This is a backport of #941, except it needs to work around the fact that we can't modify the `time` crate.
* math is 0 based while ordinal is 1 based => fix as 1 based logic
* add extensive testing against the "date" command format
* format: test sample instead of every day
* 2007 starts with saturday
* Last day of the year is thus the 52 on Monday weekly calendar, 53 on Sunday weekly calendar.
* update %U expected value in test
* Was the goal was to have a different value than with %W at next line ? another date to pick ?
* update cfg("unix") into cfg(target_os = "linux")
* format tests/dateutils.rs
tests for weeks_from and num_days_from fix array iter MSRV issue
Currently, iana-tiime-zone is only used on cfg(unix). This crate, and its windows code in particular, contains a lot of unsafe, so it seems prudent to limit its scope to where it is actually needed.
This fixes #295. PartialEq and PartialOrd are implemented by directly comparing the internal integer field, which includes the flags value.
|
Going to merge this proactively to avoid it bitrotting again (and unblock other things downstream). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: merge this with a merge commit.