Support filtering timezone names by regex #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to only install the regex build dependency with the `features = ["filter-by-regex"]` option in Cargo.toml. This commit is broken -- build.rs will get a new trivial implementation in the next commit. Deleting and creating the file in separate commits causes git's rename logic to kick in, making the diff much more useful.
quodlibetor
force-pushed
the
filter-by-regex
branch
from
5dc2bd1
to
e2daab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to only construct the tz enum variants based on a filtering Regex.
This is exactly #57 with a cleaned up history and a couple extra commits from me.