Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Optional collection configuration on client side #2523

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Jul 16, 2024

Closes #2510

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Makes Collection configuration optional on the client-side to make chroma clients work with Chroma server <=0.5.3

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

Copy link
Contributor Author

tazarov commented Jul 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov tazarov requested review from atroyn and HammadB July 16, 2024 13:50
@atroyn
Copy link
Contributor

atroyn commented Jul 16, 2024

This isn't a bug, the new client is not compatible with the old server version. The fix is for users to upgrade. We can do a better job of communicating version incompatibility as documented here: #2510 (comment)

I also don't think this approach correctly solves the problem; passing {} as a configuration and loading it the way it's loaded here will break on the server side once the server is actually updated.

@atroyn atroyn closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: 'NoneType' object has no attribute 'get'
2 participants