Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] delete collection during teardown of state machine #2521

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

codetheweb
Copy link
Contributor

Hoping that this will fix an issue on our nightly tests where the runner seems to crash without giving a reason--often can be due to CPU/memory starvation.

Hoping that this will fix an issue on our nightly tests where the runner seems to crash without giving a reason--often can be due to CPU/memory starvation.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review July 15, 2024 23:45
@codetheweb codetheweb enabled auto-merge (squash) July 16, 2024 00:07
@codetheweb codetheweb merged commit 2722be0 into main Jul 16, 2024
66 checks passed
@tazarov
Copy link
Contributor

tazarov commented Jul 16, 2024

@codetheweb, we've observed this quite some time ago, and the speculation at the time was that the default GH runners have too little memory, thus containers getting killed due to OOM. If this behaviour persists I'd suggest (and I think we may even had a PR, closed by now surely) adding a post-mortem step to dump the docker stated so we can look at the oom killed flag.

@codetheweb codetheweb deleted the fix-delete-collection-on-state-machine-teardown branch July 16, 2024 16:54
@codetheweb
Copy link
Contributor Author

@codetheweb, we've observed this quite some time ago, and the speculation at the time was that the default GH runners have too little memory, thus containers getting killed due to OOM. If this behaviour persists I'd suggest (and I think we may even had a PR, closed by now surely) adding a post-mortem step to dump the docker stated so we can look at the oom killed flag.

if you happen to have a link to that PR would love to see it, part of the challenge is that GH doesn't seem to fully retain logs when a runner dies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants