Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Timeout for s3 storage #2370

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[ENH] Timeout for s3 storage #2370

merged 1 commit into from
Jun 18, 2024
+37 −0

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jun 18, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Timeout for s3 storage
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented Jun 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite Graphite

This was referenced Jun 18, 2024
Merged
Merged
@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented Jun 18, 2024 •
edited
Loading

Merge activity

  • Jun 18, 4:00 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.
  • Jun 18, 4:03 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 18, 4:42 PM EDT: @HammadB merged this pull request with Graphite.

@HammadB HammadB changed the base branch from hammad/log_timeout to main June 18, 2024 20:01
@HammadB HammadB merged commit 56d90e1 into main Jun 18, 2024
64 checks passed
Anush008 pushed a commit to Anush008/chroma that referenced this pull request Jun 27, 2024
@HammadB @Anush008
[ENH] Timeout for s3 storage (chroma-core#2370)
f748a66 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Timeout for s3 storage
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia sanketkedia approved these changes

@Ishiihara Ishiihara Awaiting requested review from Ishiihara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HammadB @sanketkedia