[CLN] Refactor log materializer to not need to pass in offset id explicitly for readers #2354
+47
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
sanketkedia
changed the title
sanketkedia
changed the title
4 tasks
HammadB
reviewed
Jun 17, 2024
| @@ -113,7 +113,7 @@ impl CompactionManager { | |||
| dispatcher.clone(), | |||
| None, | |||
| None, | |||
| Arc::new(AtomicU32::new(1)), | |||
There was a problem hiding this comment.
Yes. This is the default value that we are passing in case the segment is uninitialized. Previously we were passing the next_offset_id (as opposed to curr_max_offset_id). I changed that to pass curr_max_offset_id now.
HammadB
reviewed
Jun 17, 2024
| let materializer = | ||
| LogMaterializer::new(record_segment_reader, input.filtered_log.clone(), offset_id); | ||
| LogMaterializer::new(record_segment_reader, input.filtered_log.clone(), None); |
There was a problem hiding this comment.
Why were we loading it before?
There was a problem hiding this comment.
We still need to read the curr_max_offset_id from the record segment. For readers, the onus of doing that has shifted to the materializer now. And writers need to still pass it explicitly since all the writer threads need to share the same curr_max_offset_id.
HammadB
approved these changes
Jun 17, 2024
sanketkedia
force-pushed
the
refactor_offset_id_materializer
branch
from
d088e99
to
2f76cb8
Compare
sanketkedia
force-pushed
the
refactor_offset_id_materializer
branch
from
2f76cb8
to
c4199a4
Compare
Anush008
pushed a commit
to Anush008/chroma
that referenced
this pull request
Jun 27, 2024
…icitly for readers (chroma-core#2354) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes Readers can pass None for the current offset id when materializing and the materializer takes care of using the correct value by reading from the record segment. Writers still need to pass it in since it is shared by writers of different partitions. ## Test plan - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Readers can pass None for the current offset id when materializing and the materializer takes care of using the correct value by reading from the record segment. Writers still need to pass it in since it is shared by writers of different partitions.
Test plan
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None