Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Cohere v5 support (Python-only) #2262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented May 30, 2024

Closes #2258

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds support for Cohere v5 client that introduced a new way to generate the client that breaks existing code

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 9:14am

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

tazarov commented May 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

@tazarov tazarov added the EF Embedding Functions label May 30, 2024
@tazarov tazarov requested a review from atroyn May 31, 2024 14:41
@tazarov tazarov force-pushed the trayan-05-30-fix_cohere_v5_support_python_ branch from fc3c4cc to 9999534 Compare June 21, 2024 13:59
@tazarov
Copy link
Contributor Author

tazarov commented Jun 21, 2024

@atroyn, this is now ready for merge after the EF split up.

@abdullahkady
Copy link

Hey @tazarov. Thank you for the PR!
Is there anything I can do from the cohere-sdk side to help get it merged?

@tazarov
Copy link
Contributor Author

tazarov commented Jul 16, 2024

@abdullahkady, thanks for pinging me on this. I'm waiting for @atroyn's review. Let me check up with him.

@tazarov tazarov force-pushed the trayan-05-30-fix_cohere_v5_support_python_ branch from 9999534 to 6cffafe Compare July 16, 2024 11:16
@tazarov tazarov requested review from atroyn and removed request for atroyn July 26, 2024 05:44
@tazarov
Copy link
Contributor Author

tazarov commented Jul 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EF Embedding Functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cohere embedding ValueError
2 participants