Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CHROMA_SERVER_NOFILE cannot be overriden with env var in container #2209

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented May 15, 2024

Description of changes

Ref: #1404

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • CHROMA_SERVER_NOFILE is not correctly overriden by user env var provided in docker compose or .env file; defaults to 65536 otherwise.

Test plan

How are these changes tested?

Manually tested

Documentation Changes

N/A

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:41pm

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

tazarov commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

@tazarov tazarov force-pushed the trayan-05-15-bug_chroma_server_nofile_cannot_be_overriden_with_env_var_in_container branch from 7db70a9 to 23034d0 Compare July 16, 2024 11:04
@tazarov tazarov merged commit b148bf0 into main Jul 16, 2024
66 checks passed
@tazarov tazarov deleted the trayan-05-15-bug_chroma_server_nofile_cannot_be_overriden_with_env_var_in_container branch July 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants