-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: FastEmbed embedding function support #1986
base: main
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
@Anush008, thanks for this. It looks good. Can I ask you to add a Docs PR—https://github.com/chroma-core/docs/pulls? I can add that, too. |
Will do. |
Associated docs PR: chroma-core/docs#233. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit about batch size and threads
Hi @tazarov. Just bumping this PR, since there are a lot of them. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello @tazarov. FYI, I've refactored the implementation into a separate file, as per the recent changes. |
Description of changes
Test plan
Unit test has been set up.
Tests pass locally with
pytest
for python.Documentation Changes