Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] FE talks to logservice #1793

Merged
merged 16 commits into from
Mar 1, 2024
Merged

[ENH] FE talks to logservice #1793

merged 16 commits into from
Mar 1, 2024

Conversation

weiligu
Copy link
Contributor

@weiligu weiligu commented Feb 29, 2024 •
edited
Loading

Description of changes

https://linear.app/trychroma/issue/CHR-242/fe-talks-to-log-service

  • FE talks to logservice

Test plan

How are these changes tested?

  • test_logservice

@weiligu Graphite App
Copy link
Contributor Author

weiligu commented Feb 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @weiligu and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@weiligu weiligu changed the title logservice [ENH] FE talks to logservice Feb 29, 2024
@weiligu weiligu added the enhancement New feature or request label Feb 29, 2024
@weiligu weiligu marked this pull request as ready for review February 29, 2024 22:47
HammadB
HammadB reviewed Feb 29, 2024
View reviewed changes
chromadb/test/test_logservice.py Outdated
@@ -0,0 +1,147 @@
# type: ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should plug this into test_producer_consumer if that makes sense (I would have to look at the test again to be sure)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that test doesn't go through front end apis and main logic is testing topic assignments and seqIds. Since we don't need that for logservice, I create a new test. We can clean up the interface later when we have time.

HammadB
HammadB reviewed Feb 29, 2024
View reviewed changes
chromadb/logservice/logservice.py
if not self._running:
raise RuntimeError("Component not running")

return self.submit_embeddings(topic_name, [embedding])[0] # type: ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why is type ignore needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because grpc returns auto, I think there's a way to generate protos with type, need to find that out

HammadB
HammadB approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I would check if we can use test_producer_consumer.py, would be nice to get that if it makes sense. Also can we turn this test on in CI in the workflow?

@weiligu
Copy link
Contributor Author

weiligu commented Feb 29, 2024

This is fine. I would check if we can use test_producer_consumer.py, would be nice to get that if it makes sense. Also can we turn this test on in CI in the workflow?

yes, let me add that to git workflow

HammadB
HammadB reviewed Mar 1, 2024
View reviewed changes
chromadb/test/test_logservice.py Outdated
@@ -0,0 +1,147 @@
# type: ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefer not to type: ignore the whole file..

@weiligu weiligu force-pushed the 02-27-FE_talks_to_log_service branch from b355dc5 to 1e5c3fd Compare March 1, 2024 08:13
@weiligu weiligu merged commit 091e466 into main Mar 1, 2024
119 checks passed
atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@weiligu @atroyn
[ENH] FE talks to logservice (chroma-core#1793)
4903277 
## Description of changes
https://linear.app/trychroma/issue/CHR-242/fe-talks-to-log-service
- FE talks to logservice

## Test plan
*How are these changes tested?*

- [ ] test_logservice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

@nicolasgere nicolasgere Awaiting requested review from nicolasgere

@Ishiihara Ishiihara Awaiting requested review from Ishiihara

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiligu @HammadB