Added support for a meta gzipped message serialization #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ression of uncompressed serializers. Created extension methods to ease the creation of gzipped serialization from existing implementations of (de)serializers. Created unit tests to verify expected functionality. Revised .gitignore to exclude VS code specific files. Upgraded package dependencies to the extent possibly without revising target frameworks.
megakid
requested changes
Jan 1, 2019
megakid
reviewed
Jan 1, 2019
megakid
reviewed
Jan 1, 2019
| this IMessageDeserializer<TMessage> messageDeserializer | ||
| ) where TMessage : class { | ||
| var gzippedMessageSerializer = messageDeserializer as GZippedMessageDeserializer<TMessage>; | ||
| if (gzippedMessageSerializer != null) { |
There was a problem hiding this comment.
if (messageDeserializer is GZippedMessageDeserializer<TMessage>) {
megakid
reviewed
Jan 1, 2019
Revised Gzipped message serializer and deserializer extension methods sanity check for improved readability. Revised GZippedMessageSerializer to make use of the instance compression level passed upon construction.
megakid
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for a meta gzipped message serializer to allow the compression of uncompressed serializers.
This change was inspired by Obvs.Serialization.Json which provides a custom GZipped implementation that can be made agnostic and decoupled from the underlying serializer. For instance, if one were to add a YAML serializer there would be no need to rewrite the compression/decompression logic as it should be agnostic to the way contents are serialized. The user will be in charge of deciding whether it makes sense to combine the gzipped serialization with another serializer.
Created extension methods to ease the creation of gzipped serialization from existing implementations of (de)serializers.
Created unit tests to verify expected functionality.
Revised .gitignore to exclude VS code specific files.
Upgraded package dependencies to the extent possible without revising target frameworks.