Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add installation and complete usage guide #9

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

christoph-fricke
Copy link
Owner

This PR adds documentation about using OpenAPI-MSW.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2023

🦋 Changeset detected

Latest commit: fa52160

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-msw Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
npm i -D openapi-msw
```

**Note:** This package has a peer-dependency to MSW **v2**. There is no plan to

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opinionated structuring idea: Add a "Prerequisites" section before installation, containing this note and the first paragraph of the usage guide. That way, its clear what needs to be done before installing this package makes sense. Also, the "Usage Guide > Getting Started" subsection title might obsolete then.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am considering other changes to the docs as well, such as a list of key features/achievements in in the beginning and and outlining the motivation behind openapi-msw, i.e. errors for spec conflicts across the stack (app + test code). I will keep this idea in mind and come back to it when I make other improvements to the docs as well.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@christoph-fricke christoph-fricke merged commit 6364870 into main Oct 23, 2023
1 check passed
@christoph-fricke christoph-fricke deleted the docs/README branch October 23, 2023 18:40
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants