-
Notifications
You must be signed in to change notification settings - Fork 1.1k
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did not trigger sell on target price #163
Comments
Hmm, I can see you are using PR 77. As you mentioned, it should've notified with the order result, but it didn't. If the Binance API throws an exception, it should be sent to Slack with the execution failed error - https://github.com/chrisleekr/binance-trading-bot/blob/feature-monitoring-simultaneously/app/cronjob/trailingTrade.js#L181 So didn't you get any further message after that? |
yep, no more further message, when it happens, it floods my slack channel |
@jl9404 |
when it happens i tried to use my api key & secret to request binance api directly, it seems no problem and not getting blocked. |
You mentioned Is it like over 10 orders?
|
its around 5 coins to be sold
|
Ok, right so 5 symbols trying to place an order actively. If you see the above comment, I calculated API usage of the bot. I will need to update the weight calculation, but would you be able to count how many orders were trying to make within a minute? |
18 orders |
@jl9404 Let me redo the calculation. |
yeah, after i restart the WSL2 it starts to sell, but the weird point is restarting docker doesnt help 🤔 |
I still suspect API limit. I mean you restarted docker and then a few mins later, you restarted WSL2 right? |
i tried |
That is odd. Let's start a bit by bit. Let me stop my bot and calculate API weights. And make sure it was not that. |
It's definitely API limt. Odd that was not reported to Slack. Binance has changed weight for
I will need to check the used weight and put the bot on hold the bot until API weight is cleared. |
thanks! |
It will take some time because I need to refactor some code. I wanna say try not to use aggressive configuration for now, but 🤷 it's up to you! |
Ok @jl9404 I have updated PR #77 to check API limit before placing an order.
Try to update your bot and see whether that issue occurs again or not. Let me know. |
hmm, still having the issue after pulling the #77
and those sellable symbols are locked 🤔 Update 1: it seems a clock sync issue, but it wont send error to slack
|
Oh oh, nice catch on error.
That can cause when the response is not received within the expected time or your machine time is not synced Refer this ccxt/ccxt#936 (comment) Try with syncing the time first. |
yep, it works fine after i sync the clock |
Ahhhh good to hear. Actually, now I understand why you didn't receive the following message because I excluded that error!
Not actually, I found the error is happening based on your network situation. Very good. So this was a time sync issue again. Would you mind putting your steps to Wiki, please? https://github.com/chrisleekr/binance-trading-bot/wiki/Troubleshooting And close the issue :) |
…ements (#77) - Updated frontend to display version - #59 - Support monitoring multiple coins simultaneously - #77 - Added docker-stack.yml for the Portainer - @hipposen - Fixed precision issues for some FIAT - #90 - Improved frontend & settings UI - #93 #85 - Support all symbols - #104 - Added stop loss feature - #99 - Stabilised Local Tunnel, cronjob and Binance WebSocket - Prevented to place new order when the API limit reached - #163 - Added NPM task for building docker image on Windows by @garyng - #175 Co-authored-by: GaryNg <garyng.zhongbo@gmail.com>
Description
When a bot ran for ~1 day, the bot did not trigger sell on target price
but it does send the message to slack but normally there should be a binance api respond follow, but it does not show up
I am using WSL2 to host the bot, I am not sure it relates to the "bug"? I restart the WSL2 and start the bot again, everything starts working again
To Reproduce
I dont know, after ran for 1 day it happens
Expected Behaviours
It should trigger sell on target price
Screenshots
The text was updated successfully, but these errors were encountered: