Enhancement #2
Merged
Enhancement #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factors of the methods. Bays also now processes defaults more simply and includes built-in fallback defaults (tertiary defaults) in case a specific and default setting isn't provided. Not available for some settings.
…ameters as input to improve clarity.
…ted detector setup method to apply settings to detectors consistent with refactor of detectors.
Update Config handler to process for new parameters.
…to a 'status' and a state property. Status is used to set the desired operating status of the detector (and thus the sensor). State reports the actual operating state of the sensor. This both cleans up a lot of cruft and allows for cleaner detection of errors, when status and state are not tracking.
…tus internally as well.
…s-through properties for state and fault. Additional debugging and decrufting.
…ion to network module based on object states. Phasing out topic dict. Restructing MQTT topics to put detector values under their own bay subtopic and split out values into their own entities, rather than packing things into JSON values. Home Assistant discovery NOT reworked yet.
Fix log level determination for bays and detectors. Add core.system_state to track overall system state. This allows flagging when the system is shutting down and preventing sending some wonky MQTT messages.
…add info logging of time elapsed.
…'re sensor readings. This is for debugging, don't expect they'll be needed in production.
Override repetition setting and send all payloads for 15s after discovery to ensure HA picks up values for new entities. Additional discovery elements.
…with current structures.
- Create class-level dict to store AW9523 objects, make sure there aren't duplicates. - New utility method to set all AW9523 pins off when AW9523 object is created. - Improvments to Sensor error handling.
…urther development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in latest enhancements and bugfixes. System is now pretty much stable and can gracefully handle errors when encountered. Most work is around glitchy sensors during operations.