Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add English Readme #22

Merged
merged 5 commits into from
Nov 24, 2016
Merged

Add English Readme #22

merged 5 commits into from
Nov 24, 2016

Conversation

PeterTeng
Copy link
Contributor

@PeterTeng PeterTeng commented Nov 24, 2016 •
edited
Loading

WHY

Check issue #21

TODO

@coveralls
Copy link

coveralls commented Nov 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9fa3e9e on PeterTeng:peter/en-readme into 87d99a4 on chocoby:master.

@coveralls
Copy link

coveralls commented Nov 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2ffdc71 on PeterTeng:peter/en-readme into 87d99a4 on chocoby:master.

@coveralls
Copy link

coveralls commented Nov 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 41e5d30 on PeterTeng:peter/en-readme into 87d99a4 on chocoby:master.

chocoby
chocoby reviewed Nov 24, 2016
View reviewed changes
Copy link
Owner

@chocoby chocoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 点、未翻訳の部分がありましたので対応していただけると助かります。
その他はリンクの位置を含め、良いと思います 👏

README_EN.md
# => "関東"
```

以下のように書くことも可能です:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日本語が残っていました 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今修正しました！

README.md
@@ -1,5 +1,7 @@
# JpPrefecture

[**English**](README_EN.md)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PeterTeng PeterTeng changed the title [WIP] Add English Readme Add English Readme Nov 24, 2016
@PeterTeng
Copy link
Contributor Author

@chocoby

Typo checkとリンクチェックは一度行いました。
レビューをお願いします🙇

@coveralls
Copy link

coveralls commented Nov 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0615033 on PeterTeng:peter/en-readme into 87d99a4 on chocoby:master.

@chocoby
Copy link
Owner

chocoby commented Nov 24, 2016

確認しました 👍
ご対応ありがとうございます！

@chocoby chocoby merged commit af68cce into chocoby:master Nov 24, 2016
@PeterTeng PeterTeng deleted the peter/en-readme branch November 24, 2016 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chocoby chocoby chocoby left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterTeng @coveralls @chocoby