Skip to content

Commit

Permalink
missed an addition to internal schema checks
Browse files Browse the repository at this point in the history
  • Loading branch information
raj-nimble committed Sep 11, 2024
1 parent 64221a8 commit 623467b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion serde_arrow/src/internal/schema/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,10 @@ fn validate_time64_field(field: &Field, unit: TimeUnit) -> Result<()> {
fn validate_struct_field(field: &Field, children: &[Field]) -> Result<()> {
// NOTE: do not check number of children: arrow-rs can 0 children, arrow2 not
match get_strategy_from_metadata(&field.metadata)? {
None | Some(Strategy::MapAsStruct) | Some(Strategy::TupleAsStruct) => {}
None
| Some(Strategy::MapAsStruct)
| Some(Strategy::TupleAsStruct)
| Some(Strategy::EnumsWithNamedFieldsAsStructs) => {}
Some(strategy) => fail!("invalid strategy for Struct field: {strategy}"),
}
for child in children {
Expand Down
1 change: 1 addition & 0 deletions serde_arrow/src/internal/schema/strategy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ impl FromStr for Strategy {
"NaiveStrAsDate64" => Ok(Self::NaiveStrAsDate64),
"TupleAsStruct" => Ok(Self::TupleAsStruct),
"MapAsStruct" => Ok(Self::MapAsStruct),
"EnumsWithNamedFieldsAsStructs" => Ok(Self::EnumsWithNamedFieldsAsStructs),
"UnknownVariant" => Ok(Self::UnknownVariant),
_ => fail!("Unknown strategy {s}"),
}
Expand Down

0 comments on commit 623467b

Please sign in to comment.