This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chick
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very nice simplification
A lot of the code before was dealing with using a Docker image for dependencies like Verilator; none of which are needed by this repo. I suspect we'll want to refer back to it if we were to move Chisel or FIRRTL to Github Actions. That being said, we might as well make it as simple as possible for Treadle since we have that luxury 🙂 |
Also some of it was for building dependencies which becomes unnecessary with the auto SNAPSHOT publishing |
jackkoenig
force-pushed
the
update-ci
branch
from
November 18, 2020 23:31
3939b64
to
492d080
Compare
@Mergifyio backport 1.3.x 1.2.x |
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2020
(cherry picked from commit 7e46a00)
Command
|
jackkoenig
added a commit
that referenced
this pull request
Nov 19, 2020
jackkoenig
added a commit
that referenced
this pull request
Nov 19, 2020
(cherry picked from commit 7e46a00)
jackkoenig
added a commit
that referenced
this pull request
Nov 19, 2020
This was referenced Nov 24, 2020
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP