Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix problems caused by PadWidths creating Dshlw #238

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Fix problems caused by PadWidths creating Dshlw #238

merged 1 commit into from
Aug 14, 2020

Conversation

chick
Copy link
Collaborator

@chick chick commented Aug 10, 2020

  • Switch to using Forms.LowForm
  • Include other optimizations from
    • LowFormMinimumOptimized
    • LowFormOptimized
    • without those passes some treadle tests take 25X longer to run

@chick
Fix problems caused by PadWidths creating Dshlw
29d03e0 
- Switch to using Forms.LowForm
- Include other optimizations from
  - LowFormMinimumOptimized
  - LowFormOptimized
  - without those passes some treadle tests take 25X longer to run
@chick chick added bug Something isn't working release issue labels Aug 10, 2020
@chick chick added this to the 1.3.x milestone Aug 10, 2020
@chick chick requested a review from a team as a code owner August 10, 2020 20:59
@chick chick self-assigned this Aug 10, 2020
@ekiwi-sifive
Copy link
Collaborator

Does this solve the problem? It seems like PadWidths would still be scheduled since some of the optimization passes depend on PadWidths.

@ekiwi-sifive
Copy link
Collaborator

@chick if you could add the test case where you see a Dshlw to the treadle test suite, I could have a look at it.

@chick chick mentioned this pull request Aug 12, 2020
Closed
@chick
Copy link
Collaborator Author

chick commented Aug 14, 2020

@ekiwi-sifive @jackkoenig could I get an review of this please. It's one of the pieces needed for dshlw fix, other pr's are approved.

ekiwi
ekiwi approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@chick chick merged commit 9e928c3 into master Aug 14, 2020
@seldridge seldridge mentioned this pull request Aug 17, 2020
Closed
13 tasks
@jackkoenig jackkoenig modified the milestones: 1.3.x, 1.3.0 Nov 17, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ekiwi ekiwi ekiwi approved these changes

@seldridge seldridge Awaiting requested review from seldridge

@ekiwi-sifive ekiwi-sifive Awaiting requested review from ekiwi-sifive

Assignees

@chick chick

Labels
bug Something isn't working release issue
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chick @ekiwi-sifive @ekiwi @jackkoenig