Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add github action/workflow testing #192

Merged
merged 4 commits into from
Apr 28, 2020
Merged

Add github action/workflow testing #192

merged 4 commits into from
Apr 28, 2020

Conversation

chick
Copy link
Collaborator

@chick chick commented Apr 28, 2020

Copied firrtl-interpreter github ci

@chick chick added the enhancement New feature or request label Apr 28, 2020
@chick chick requested a review from ucbjrl April 28, 2020 16:13
@chick chick requested a review from a team as a code owner April 28, 2020 16:13
@chick chick self-assigned this Apr 28, 2020
ucbjrl
ucbjrl suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@ucbjrl ucbjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of this PR should be "Add GitHub Action/Workflow testing". It's not using Travis.

@chick chick changed the title Add travis testing Add github action/workflow testing Apr 28, 2020
@chick
Copy link
Collaborator Author

chick commented Apr 28, 2020

Fixed title of PR, I also renamed branch, but that doesn't seem to have changed it here.

ucbjrl
ucbjrl approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@ucbjrl ucbjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chick chick merged commit 3495ed0 into master Apr 28, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ucbjrl ucbjrl ucbjrl approved these changes

Assignees

@chick chick

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chick @ucbjrl