This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fix code analysis problem introduced with #154 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some too long lines etc.
ucbjrl
approved these changes
Dec 4, 2019
ucbjrl
added a commit
that referenced
this pull request
Feb 19, 2020
* Merge pull request #150 from freechipsproject/fix-test-dir-name-making Fixed bug in Treadles internal default test directory naming (cherry picked from commit eefbdb9) * Merge pull request #153 from freechipsproject/datastore-plugin-match-in-repl Fixes incomplete match specification of a datastore plugin in repl (cherry picked from commit 1fad437) * Merge pull request #152 from freechipsproject/better-stop-result Provide API for getting stop result in from treadle tester (cherry picked from commit cf60353) * Merge pull request #154 from freechipsproject/riscv-mini-fixes Fixes for problem discovered in riscv-mini (cherry picked from commit 5e7e480) * Merge pull request #155 from freechipsproject/printf-format-like-verilator Makes treadle printf output formatted more like verilator does (cherry picked from commit ad79d0c) * Merge pull request #156 from freechipsproject/fix-shl-eta-expansion Fix code analysis problem introduced with #154 (cherry picked from commit 547d249) * Merge pull request #157 from freechipsproject/fix-vcd-root-name The vcd filename can be wrong (cherry picked from commit d8b18b9) * Merge pull request #159 from freechipsproject/fix-printf-match-verilator-2 Make printf behavior more closely match verilator (cherry picked from commit ea3b725) * Bump minor version Co-authored-by: Chick Markley <chick@qrhino.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix is to correct an eta expansion notation in shl processing.
Did a minor bit of code cleanup found during fix.
Fix some too long lines etc.