This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
BlackBoxSourceHelper: ensure trailing newline in .f file #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
approved these changes
Nov 4, 2021
| @@ -135,7 +135,7 @@ class BlackBoxSourceHelper extends Transform with DependencyAPIMigration { | |||
| // make[1]: *** No rule to make target `test_run_dir/examples.AccumBlackBox_PeekPokeTest_Verilator345491158/AccumBlackBox.v', needed by `.../chisel-testers/test_run_dir/examples.AccumBlackBox_PeekPokeTest_Verilator345491158/VAccumBlackBoxWrapper.h'. Stop. | |||
| // or we end up including the same file multiple times. | |||
| if (verilogSourcesOnly.nonEmpty) { | |||
| writeTextToFile(verilogSourcesOnly.map(_.getCanonicalPath).mkString("\n"), filelistFile) | |||
| writeTextToFile(verilogSourcesOnly.map(_.getCanonicalPath).mkString("\n") + "\n", filelistFile) | |||
There was a problem hiding this comment.
Suggested change
| writeTextToFile(verilogSourcesOnly.map(_.getCanonicalPath).mkString("\n") + "\n", filelistFile) | |
| writeTextToFile(verilogSourcesOnly.map(_.getCanonicalPath).mkString("", "\n", "\n"), filelistFile) |
Just an FYI that there is a 3 argument mkString that has start and end arguments as well. Generally it's just a stylistic choice but since that append requires an extra String copy, it could be useful for very large Strings. Probably fine to leave as is in this case though.
ekiwi
added
the
Please Merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like some simulators require a trailing newline in every
.ffile: ucb-bar/chiseltest#429 (comment)Contributor Checklist
Type of Improvement
API Impact
Backend Code Generation Impact
Desired Merge Strategy
Reviewer Checklist (only modified by reviewer)
Please Merge?