Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Fix mill compile #2147

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Fix mill compile #2147

merged 2 commits into from
Mar 22, 2021

Conversation

sequencer
Copy link
Member

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

None

Backend Code Generation Impact

None

Desired Merge Strategy

  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

.github/workflows/test.yml Show resolved Hide resolved
@sequencer sequencer force-pushed the mill_fix branch 2 times, most recently from eb4bd33 to f00c7ab Compare March 22, 2021 19:11
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@ekiwi ekiwi added this to the 1.4.x milestone Mar 22, 2021
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Mar 22, 2021
@ekiwi ekiwi merged commit 09c4baf into master Mar 22, 2021
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Mar 22, 2021
@jackkoenig jackkoenig deleted the mill_fix branch March 26, 2021 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants