Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Remove Scala 2.11 #2062

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Remove Scala 2.11 #2062

merged 1 commit into from
Mar 2, 2021

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Jan 29, 2021 •
edited
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code refactoring
  • code cleanup

API Impact

It removes support for Scala 2.11

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Removed support for Scala 2.11. Please see https://www.chisel-lang.org/chisel3/upgrading-from-scala-2-11.html and use Chisel 3.4 and FIRRTL 1.4 to migrate code to Scala 2.12.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 1.5.0 milestone Jan 29, 2021
ekiwi
ekiwi reviewed Jan 29, 2021
View reviewed changes
src/test/scala/firrtl/backends/experimental/smt/end2end/SMTCompilationTest.scala Outdated
@@ -15,8 +15,7 @@ import scala.sys.process.{Process, ProcessLogger}
class SMTCompilationTest extends AnyFlatSpec with LazyLogging {
it should "generate valid SMTLib for AddNot" taggedAs (RequiresZ3) in { compileAndParse("AddNot") }
it should "generate valid SMTLib for FPU" taggedAs (RequiresZ3) in { compileAndParse("FPU") }
// we get a stack overflow in Scala 2.11 because of a deeply nested and(...) expression in the sequencer
it should "generate valid SMTLib for HwachaSequencer" taggedAs (RequiresZ3) ignore {
it should "generate valid SMTLib for HwachaSequencer" taggedAs (RequiresZ3) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

azidar
azidar approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@azidar azidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor whitespace change, otherwise LGTM.

src/main/scala/firrtl/stage/FirrtlAnnotations.scala Outdated Show resolved Hide resolved
@jackkoenig jackkoenig mentioned this pull request Mar 2, 2021
Merged
11 tasks
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Mar 2, 2021
@jackkoenig
Copy link
Contributor Author

Red X is just that Mergify can't merge changes to the CI workflow

@jackkoenig jackkoenig merged commit 38dc540 into master Mar 2, 2021
@jackkoenig jackkoenig deleted the farewell_scala_211 branch March 2, 2021 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ekiwi ekiwi ekiwi left review comments

@azidar azidar azidar approved these changes

Assignees
No one assigned
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jackkoenig @ekiwi @azidar