Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Add newline in the end of LoFIRRTL file #2015

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Add newline in the end of LoFIRRTL file #2015

merged 1 commit into from
Dec 10, 2020

Conversation

itviewer
Copy link
Contributor

fix #2012

Type of Improvement

bug fix

API Impact

No

Backend Code Generation Impact

No

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi ekiwi self-requested a review December 10, 2020 17:21
@ekiwi
Copy link
Contributor

ekiwi commented Dec 10, 2020

This looks great to me!

@ekiwi ekiwi added this to the 1.4.x milestone Dec 10, 2020
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Dec 10, 2020
ekiwi
ekiwi approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mergify mergify bot merged commit 5fb8845 into chipsalliance:master Dec 10, 2020
mergify bot pushed a commit that referenced this pull request Dec 10, 2020
@itviewer
Add newline in the end of LoFIRRTL file (#2015)
33a13de 
(cherry picked from commit 5fb8845)
@mergify mergify bot mentioned this pull request Dec 10, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Dec 10, 2020
@jackkoenig
Copy link
Contributor

Should we backport this further to 1.2.x and 1.3.x?

mergify bot added a commit that referenced this pull request Dec 10, 2020
@mergify @itviewer
Add newline in the end of LoFIRRTL file (#2015) (#2016)
683f9e2 
(cherry picked from commit 5fb8845)

Co-authored-by: XinJun Ma <xinjun.ma@qq.com>
@ekiwi
Copy link
Contributor

ekiwi commented Dec 10, 2020

Should we backport this further to 1.2.x and 1.3.x?

This is using the new fast serializer that I added for 1.4 so I doubt it will cleanly apply to older versions. This might also be a regression introduced by my new serializer (haven't checked)

@jackkoenig
Copy link
Contributor

Good point, if we need to do different fixes for other stable branches we can cross that bridge when we come to it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ekiwi ekiwi ekiwi approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.4.x
Development

Successfully merging this pull request may close these issues.

The end of the LoFIRRTL file should end with DEDENT
3 participants
@itviewer @ekiwi @jackkoenig