Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize scala.util.control.NonFatal in Builder #4195

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jackkoenig
Copy link
Contributor

Chisel includes logic to trim NonFatal stack traces. OutOfMemoryErrors (e.g. from running out of heap or stack) can cause weird issues where because the JVM is out of memory, scala.util.control.NonFatal cannot be loaded to compare to and then the JVM masks the real OutOfMemoryError by throwing a LinkageError.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Chisel includes logic to trim NonFatal stack traces. OutOfMemoryErrors
(e.g. from running out of heap or stack) can cause weird issues where
because the JVM is out of memory, scala.util.control.NonFatal cannot be
loaded to compare to and then the JVM masks the real OutOfMemoryError by
throwing a LinkageError.
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jun 20, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Jun 20, 2024
@jackkoenig jackkoenig merged commit 0baa8fd into main Jun 20, 2024
18 checks passed
@jackkoenig jackkoenig deleted the initialize-nonfatal branch June 20, 2024 22:08
@mergify mergify bot added the Backported This PR has been backported label Jun 20, 2024
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
Chisel includes logic to trim NonFatal stack traces. OutOfMemoryErrors
(e.g. from running out of heap or stack) can cause weird issues where
because the JVM is out of memory, scala.util.control.NonFatal cannot be
loaded to compare to and then the JVM masks the real OutOfMemoryError by
throwing a LinkageError.

(cherry picked from commit 0baa8fd)
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
Chisel includes logic to trim NonFatal stack traces. OutOfMemoryErrors
(e.g. from running out of heap or stack) can cause weird issues where
because the JVM is out of memory, scala.util.control.NonFatal cannot be
loaded to compare to and then the JVM masks the real OutOfMemoryError by
throwing a LinkageError.

(cherry picked from commit 0baa8fd)
chiselbot pushed a commit that referenced this pull request Jun 20, 2024
Chisel includes logic to trim NonFatal stack traces. OutOfMemoryErrors
(e.g. from running out of heap or stack) can cause weird issues where
because the JVM is out of memory, scala.util.control.NonFatal cannot be
loaded to compare to and then the JVM masks the real OutOfMemoryError by
throwing a LinkageError.

(cherry picked from commit 0baa8fd)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Jun 20, 2024
Chisel includes logic to trim NonFatal stack traces. OutOfMemoryErrors
(e.g. from running out of heap or stack) can cause weird issues where
because the JVM is out of memory, scala.util.control.NonFatal cannot be
loaded to compare to and then the JVM masks the real OutOfMemoryError by
throwing a LinkageError.

(cherry picked from commit 0baa8fd)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant