Error when calling define targeting a child of a probe

[jackkoenig]

Contributor Checklist

• Did you add Scaladoc to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you add appropriate documentation in docs/src?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• Bugfix

Desired Merge Strategy

• Squash

Release Notes

This is already an error caught in firtool, now Chisel will error earlier.

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
• Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you do one of the following when ready to merge:
  • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
  • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

[dtzSiFive]

LGTM. Not 100% on details of when across all the things ChildBinding may or may not be set and such, but this makes sense and left minor feedback on some other bits.

Test certainly LGTM. Thanks for improving the experience here! 🎉

[jackkoenig]

Not 100% on details of when across all the things ChildBinding may or may not be set and such

For your benefit (and anyone else reading this), ChildBinding is the binding set for any child of a Vec or Record. That's why you see .topBinding so often, because the fact that some aggregate is a Wire or whatever is only stored in the root Data, any children (recursively) just have ChildBinding pointing to their parent Data (which may itself also have ChildBinding). Not necessarily the best representation but it's what we have 😇