-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when calling define targeting a child of a probe #4175
Error when calling define targeting a child of a probe #4175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not 100% on details of when across all the things ChildBinding may or may not be set and such, but this makes sense and left minor feedback on some other bits.
Test certainly LGTM. Thanks for improving the experience here! 🎉
3ea0182
to
61e3a26
Compare
For your benefit (and anyone else reading this), ChildBinding is the binding set for any child of a Vec or Record. That's why you see |
(cherry picked from commit 4de3581) # Conflicts: # core/src/main/scala/chisel3/internal/package.scala
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
This is already an error caught in firtool, now Chisel will error earlier.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.